Add getRawHeader() method to allow retrieving headers without charset conversion #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conversion (which sometimes generates errors)
| public function getHeader($name) | ||
| { | ||
| $rawHeader = $this->getRawHeader($name); | ||
| if($rawHeader === false) { |
There was a problem hiding this comment.
Expected 1 space after IF keyword; 0 found
|
Reviewed-by: me if you fix that PSR formatting problem. |
eXorus
added a commit
that referenced
this pull request
Nov 12, 2015
Add getRawHeader() method to allow retrieving headers without charset conversion
|
Thnaks for this solution but I would like to résolve the decoded header. What is the expected result of ? |
|
This subject comes from a spam message and is probably malformed. It looks like two separate message subjects, each encoded separately. The getRawHeader() method is supposed to provide a workaround for situations, when we receive messages with invalid headers. I'm not sure if trying to decode the headers in such cases is worth the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the subject of an e-mail cannot be decoded by iconv(), the getHeader('subject') call generates iconv() warnings. It makes it impossible to retrieve the header contents (even without decoding). I added a getRawHeader() to make it possible to access raw headers.
Sample invalid subject (consists of two parts, but decodeHeader() currently doesn't handle that):
=?GB2312?B?1rvSqsTjxNzP66Os1rvSqsTjz+vX9qOsv827p7K7ysfOyszio6zLq8+yyO28?= =?GB2312?B?/rDvxPq94r72o6GjoQ==?=