CurlFile fix #53
Merged
CurlFile fix #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not tested, but we are facing the same problem with CurlFile Uploads (php-mod#46) - This *should* do the trick.
|
Maybe a check if data is an array should be done, otherwise the foreach would throw an exception if its an object - but what could be situation with an object? |
|
Thank you for your pull request. I updated the master branch to fix tests. Can you please update your pull request with recent changes ? |
|
@amouhzi should be done, please take a look. Maybe you can trigger the build again: https://travis-ci.org/php-mod/curl/builds/455089991 |
|
(just saw you where switching to gitlab ci, well then the build badge can be removed) |
|
It doesn't pass CS tests https://gitlab.com/anezi/curl/-/jobs/121211929 Something has changed in Github, Travis or Gitlab. The tests did not turn before merging the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are facing the same problem with CurlFile Uploads (#46).
Please take a closer look at the fix in order to ensure its backwards compatible.