Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split padding in top/bottom and left/right #121

Merged
merged 7 commits into from
May 10, 2018

Conversation

Lynesth
Copy link
Collaborator

@Lynesth Lynesth commented May 10, 2018

... and breaking tests as always :)

@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

Merging #121 into master will increase coverage by 0.07%.
The diff coverage is 98.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #121      +/-   ##
============================================
+ Coverage     96.87%   96.95%   +0.07%     
- Complexity      342      356      +14     
============================================
  Files            23       23              
  Lines          1057     1117      +60     
============================================
+ Hits           1024     1083      +59     
- Misses           33       34       +1
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/AsciiArtItem.php 100% <ø> (ø) 14 <0> (ø) ⬇️
src/MenuStyle.php 96.78% <100%> (+0.78%) 70 <10> (+9) ⬆️
src/Dialogue/Flash.php 100% <100%> (ø) 1 <0> (ø) ⬇️
src/CliMenu.php 92.41% <100%> (+0.07%) 80 <0> (+2) ⬆️
src/Input/InputIO.php 98.42% <100%> (ø) 24 <0> (ø) ⬇️
src/Dialogue/Confirm.php 100% <100%> (ø) 4 <0> (ø) ⬇️
src/Dialogue/Dialogue.php 90% <100%> (ø) 8 <0> (ø) ⬇️
src/CliMenuBuilder.php 97.86% <92.3%> (-0.46%) 56 <4> (+3)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3e425...bbe785a. Read the comment docs.

@AydinHassan
Copy link
Member

Looks great - thanks! I'll take care of the tests

@AydinHassan AydinHassan merged commit 97058e0 into php-school:master May 10, 2018
@AydinHassan AydinHassan added this to the 3.0 milestone May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants