Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible to add PstlAdr in format pain.008.001.02 #88

Closed
bberjawi opened this issue Feb 11, 2020 · 1 comment
Closed

Impossible to add PstlAdr in format pain.008.001.02 #88

bberjawi opened this issue Feb 11, 2020 · 1 comment

Comments

@bberjawi
Copy link

bberjawi commented Feb 11, 2020 •
edited

It is impossible to add PstlAdr for debit with format pain.008.001.02
in CustomerDirectDebitTransferDomBuilder L171 :
if (in_array($this->painFormat, array('pain.008.003.02'))) { $addPostalAddress = false; $postalAddress = $this->createElement('PstlAdr');

The PstlAdr is allowed in format 008.001.02 (check https://businessbanking.bankofireland.com/app/uploads/2016/07/SEPA-Direct-Debit-PAIN.008.001.02-XML-File-Structure-PDF.pdf)
monofone added a commit that referenced this issue Feb 13, 2020
@monofone
Add additional pain format for PstlAdr
401375c 
As requested in #88 this adds an additional pain format to check if a PstlAdr should be added ti the xml
@monofone monofone mentioned this issue Feb 13, 2020
Merged
monofone added a commit that referenced this issue Feb 13, 2020
@monofone
Add additional pain format for PstlAdr
460072d 
As requested in #88 this adds an additional pain format to check if a PstlAdr should be added ti the xml
@monofone
Copy link
Member

should be fixed with this new release 1.6.2, if there are any issues don't mind to open a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@monofone @bberjawi