Merge pull request #31 from php-vcr/fix-soap-extend-replacement

Fix soap extend replacement
php-vcr · Jan 19, 2014 · 5c98bad · 5c98bad
2 parents a68b0f6 + 2725d16
commit 5c98bad
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/src/VCR/Configuration.php b/src/VCR/Configuration.php
@@ -36,7 +36,7 @@ class Configuration
         'post_fields' => array('VCR\RequestMatcher', 'matchPostFields'),
     );
     private $whiteList = array();
-    private $blackList = array('src/VCR/LibraryHooks/');
+    private $blackList = array('src/VCR/LibraryHooks/', 'src/VCR/Util/Soap/SoapClient');
 
     /**
      *

diff --git a/src/VCR/LibraryHooks/Soap/Filter.php b/src/VCR/LibraryHooks/Soap/Filter.php
@@ -15,7 +15,7 @@ class Filter extends AbstractFilter
 
     private static $patterns = array(
         '@new\s+\\\?SoapClient\W*\(@i',
-        '@extends\s+SoapClient\W*@i',
+        '@extends\s+\\\?SoapClient@i',
     );
 
     /**

diff --git a/tests/VCR/LibraryHooks/Soap/FilterTest.php b/tests/VCR/LibraryHooks/Soap/FilterTest.php
@@ -31,6 +31,14 @@ public function codeSnippetProvider()
                 'new \VCR\Util\Soap\SoapClient(',
                 'new SoapClient('
             ),
+            'extends \SoapClient' => array(
+                'extends \VCR\Util\Soap\SoapClient',
+                'extends \SoapClient'
+            ),
+            'extends \SoapClient with linebreak' => array(
+                "extends \VCR\Util\Soap\SoapClient\n",
+                "extends \SoapClient\n"
+            ),
             'new SoapClientExtended' => array(
                 'new SoapClientExtended(',
                 'new SoapClientExtended('