Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow function names that have keywords (e.g. raven/raven library) #102

Merged
merged 1 commit into from
Feb 19, 2015

Conversation

morrislaptop
Copy link
Contributor

This function from the raven/raven library...

function send_http_asynchronous_curl_exec($url, $data, $headers) {

was getting rewritten as

function send_http_asynchronous_\VCR\LibraryHooks\CurlHook::curl_exec($url, $data, $headers) {

resulting in...

Parse error: syntax error, unexpected '\' (T_NS_SEPARATOR), expecting '(' in /Users/craigmorris/Sites/error-tracker-adapter/vendor/raven/raven/lib/Raven/Client.php on line 572

adri added a commit that referenced this pull request Feb 19, 2015
Allow function names that have keywords (e.g. raven/raven library)
@adri adri merged commit da7ebb6 into php-vcr:master Feb 19, 2015
@morrislaptop
Copy link
Contributor Author

Great library! Can you do a new release? I'm relying on this fix for another package that is geocoder-php for error tracking services :) https://github.com/morrislaptop/error-tracker-adapter

@adri
Copy link
Contributor

adri commented Feb 19, 2015

@morrislaptop
Copy link
Contributor Author

Thanks!
On Thu, 19 Feb 2015 at 5:20 pm Adrian Philipp notifications@github.com
wrote:

Done https://github.com/php-vcr/php-vcr/releases/tag/1.2.1


Reply to this email directly or view it on GitHub
#102 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants