-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalized type names inside <type>
#2658
Comments
Types are not case-sensitive in PHP: https://3v4l.org/HMEUj For XML markup, if what we are describing is a type it should be in a type tag. Otherwise, it shouldn't. Regardless of case The issue with linking/rendering types has been an issue for a while on the PhD side and I do have a PR open for that which I probably should look into again. |
Oh, I will change my validation scripts to reflect that.
I recently fixed an issue on pt_BR where linking on |
What sort or scripts do you have? We have a |
Scripts that check if translations are defining the same attributes, entities, tags, on the same files, as the original files. Basically checking for unbalanced XML usage between They are basically QA scripts, but work by comparing two trees. With this I already catch a lot of mistyped or portly translated files on pt_BR, as some inconsistency usage. See, for example, #2664 (en) and php/doc-pt_br@eae2d59 (translation). I plan to integrate them afterwards, but I'm somewhat blocked by php/doc-base#69, as it implies there is a better licensing option for newer doc scripts. |
I don't know much about licensing, so I've shouted into the void on Mastodon. |
On
language/types/array.xml
the basic type names are capitalized, as common words, even inside<type>
tags.The
![image](https://private-user-images.githubusercontent.com/10078152/258881615-7e4f3a6b-60d7-4d2f-ba8c-4425b90bb6ff.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTgxNTUsIm5iZiI6MTcyMTE1Nzg1NSwicGF0aCI6Ii8xMDA3ODE1Mi8yNTg4ODE2MTUtN2U0ZjNhNmItNjBkNy00ZDJmLWJhOGMtNDQyNWI5MGJiNmZmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE2VDE5MjQxNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWViMzk0YjQyZmNhNzBkMzgzNTVhMWFjNTc4YzMxYWNjMDA5NTljMzc3MjBkZGFlMTAxNTA0YWUzZDlmYWIzODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.HNDUt_UW9E2tXk3G_IHRbtZVFqie2LpWfO3jikkHh8I)
<type>
tag is rendered as a normal text:I would like to change these few places where capitalized type names occurs, or to remove the surrounding type tag (or to lower the names inside the tags) as PHP types are case sensitive. There are preferences in this case? Remove the tags or to lower, all this cases?
XML source:
doc-en/language/types/array.xml
Line 89 in a0fcdcb
The text was updated successfully, but these errors were encountered: