Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more lax in function/methodnames tag in regards to whitespace #80

Open
Girgias opened this issue Aug 9, 2023 · 2 comments
Open

Be more lax in function/methodnames tag in regards to whitespace #80

Girgias opened this issue Aug 9, 2023 · 2 comments

Comments

@Girgias
Copy link
Member

Girgias commented Aug 9, 2023

I recently fixed an issue on pt_BR where linking on <function> was failing because whitespace inside the tag. So I suggest trim() and strtolower() the tag's content before calculating link targets.

Originally posted by @alfsb in php/doc-en#2658 (comment)

@alfsb
Copy link
Member

alfsb commented Aug 10, 2023

For example, the first $_POST does not link, because <varname> is broken in two lines on XML sources, as now.

Source: https://github.com/php/doc-en/blob/be90f2a70062d28df2bfe951f0fa97faee06005f/faq/using.xml#L45

      predefined variables</link>, like the superglobal <varname>
      $_POST</varname>.  You may loop through <varname>$_POST</varname>

Render:
image

@alfsb
Copy link
Member

alfsb commented Oct 25, 2023

A similar situation occurs with <constant>:

image

Source was: php/doc-en@0b26a7a#diff-717ba49111eccd44cb75e6b39de78d12c36f2d625be55b911055f5a5be133081L733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants