Clarify constructor property promotion modifiers #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartvanraaij
force-pushed
the
master
branch
from
6191972
to
3b42dc6
Compare
bartvanraaij
changed the title
bartvanraaij
force-pushed
the
master
branch
from
3b42dc6
to
64013ab
Compare
bartvanraaij
force-pushed
the
master
branch
from
64013ab
to
542d232
Compare
Girgias
approved these changes
Sep 11, 2023
Girgias
reviewed
Sep 11, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently made aware that any modifier can be used to apply constructor property promotion, instead of just visibility modifiers:
php/php-src#12122
This PR aims to clarify this in the docs.