-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated ob_get_status docs #3034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not document changes from PHP 5 any more, please remove such mentions
I broke up the markup and moved a few paragraphs around as you requested and the whole page looks much cleaner now. I also added some additional information on how some of that returned info is related to other functionality (ob_get_level() "level" being off by 1, output_buffering influencing "chunk_size") and what "flags" are returned which wasn't described anywhere else yet. I also wanted to add something about the "name" but realized that that is already explained in detail in ob_list_handlers() in my other PR (#3042) but couldn't figure out how to link to the return values section of that page. I'd still like to shorten that sentence in this PR and add that link for more details instead, so I'd appreciate any pointers on how to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just minor nits :)
Closes #3021 and https://bugs.php.net/bug.php?id=62019.