Update outdated ob_get_status docs #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Dec 24, 2023
Girgias
reviewed
Dec 27, 2023
|
I broke up the markup and moved a few paragraphs around as you requested and the whole page looks much cleaner now. I also added some additional information on how some of that returned info is related to other functionality (ob_get_level() "level" being off by 1, output_buffering influencing "chunk_size") and what "flags" are returned which wasn't described anywhere else yet. I also wanted to add something about the "name" but realized that that is already explained in detail in ob_list_handlers() in my other PR (#3042) but couldn't figure out how to link to the return values section of that page. I'd still like to shorten that sentence in this PR and add that link for more details instead, so I'd appreciate any pointers on how to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3021 and https://bugs.php.net/bug.php?id=62019.