Fix MongoDB links in the library tutorial page #3041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional slashes result in a 404 pages. E. g.: https://www.mongodb.com/docs/php-library/master/reference//class/MongoDBClient/ link contains a double-slash before "class" path's part. https://www.php.net/manual/en/mongodb.tutorial.library.php
sy-records
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
LGTM.
btw, It is also possible to modify here directly so that other language translations do not have to be modified, https://github.com/php/doc-base/blob/e4890bd6dba8e9cba8cfa154589e3d506b0af2b9/entities/global.ent#L239
|
Yes, updating this in doc-base makes more sense to me too. |
Girgias
changed the title
mmalferov
added a commit
to mmalferov/doc-base
that referenced
this pull request
Dec 27, 2023
Girgias
pushed a commit
to php/doc-base
that referenced
this pull request
Dec 27, 2023
|
Thank you, @mmalferov. Sorry for not getting a chance to review this earlier (on holiday this week). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional slashes result in a 404 pages. E. g.:
https://www.mongodb.com/docs/php-library/master/reference//class/MongoDBClient/
link contains a double-slash before "class" path's part.
https://www.php.net/manual/en/mongodb.tutorial.library.php