[skip-revcheck] Convert class markup to be compatible with DocBook 5.2 #3415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested review from
TimWolla,
kamil-tekiela and
nielsdos
as code owners
|
@kocsismate just to inform you about changes to doc format that probably need to be applied |
16 tasks
|
There is an issue with classes not being linked to but this is most likely an issue in PhD. |
|
I don't know docbook but seems fine for dom and xml stuff. |
kocsismate
approved these changes
May 27, 2024
kocsismate
added a commit
to kocsismate/php-src
that referenced
this pull request
May 28, 2024
|
Filed php/php-src#14351 for gen_stub.php |
|
The PhD PR for rendering the new markup. |
|
@Girgias Is it now mergable? |
|
This should be yes, I'll merge them manually while updating the translations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion performed with the following script: https://gist.github.com/Girgias/8fc473b7fda9007407ca85df32ad1b1d
@haszi do you see any issue in regard to rendering/indexing/search?