PHP 7.4: PCRE: document new $flags param for preg_replace_callback[_array]() #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray]() The PHP 7.4 `$flags` parameter as added to the `preg_replace_callback()` and `preg_replace_callback_array()` function was not yet included in the documentation. In this PR, I'm * Adding the parameter to the function signature. * Adding minimal parameter documentation with a reference to the more detailed explanation in the parameter documentation of the [`preg_match()`](https://www.php.net/manual/en/function.preg-match.php) function. * Adding a changelog entry for the parameter to each function. Refs: * php/php-src#3958 * https://github.com/php/php-src/blob/2f1398dad934086b605073c51af3118c8eff28b1/UPGRADING#L304-L308
jrfnl
force-pushed
the
feature/pcre-preg_replace_callback-flags-param
branch
2 times, most recently
from
4f85e79
to
cd8ca75
Compare
|
Anything I need to update for this PR to be considered ? |
|
Thanks for the ping! The patch is good, but there is no need to explicitly link functions; just marking them up as I've applied that as http://svn.php.net/viewvc?view=revision&revision=349965. PS: and thanks for the PR! :) |
Thanks, this was one of the first PRs I send in. I'm slowly learning how it all works and hopefully getting better at it ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHP 7.4
$flagsparameter as added to thepreg_replace_callback()andpreg_replace_callback_array()functions was not yet included in the documentation.In this PR, I'm
preg_match()function.🤞 I hope I've got the xml syntax right for this change. I'm not 100% familiar yet with it, so please bear with me if I've got it wrong. (and just tell me what I've got wrong & I'll fix it promptly)
Refs: