Skip to content

Commit

Permalink
Fixed bug #27580 (pre-initialization errors in ap2 handler are not being
Browse files Browse the repository at this point in the history
written to vhost error log).
Stop using depreciated and ignored APLOG_NOERRNO directive.
Make file not found & directory as script invocation error messages more
descriptive.
  • Loading branch information
Ilia Alshanetsky committed Mar 16, 2004
1 parent 1ef3c8c commit 39baa27
Showing 1 changed file with 14 additions and 7 deletions.
21 changes: 14 additions & 7 deletions sapi/apache2handler/sapi_apache2.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@

/* UnixWare and Netware define shutdown to _shutdown, which causes problems later
* on when using a structure member named shutdown. Since this source
* file does not use the system call shutdown, it is safe to #undef it.
* file does not use the system call shutdown, it is safe to #undef it.K
*/
#undef shutdown

Expand Down Expand Up @@ -283,11 +283,18 @@ static void php_apache_sapi_log_message(char *msg)
* with Apache 1.3 -- rbb
*/
if (ctx == NULL) { /* we haven't initialized our ctx yet, oh well */
ap_log_error(APLOG_MARK, APLOG_ERR | APLOG_NOERRNO | APLOG_STARTUP,
0, NULL, "%s", msg);
ap_log_error(APLOG_MARK, APLOG_ERR | APLOG_STARTUP, 0, NULL, "%s", msg);
} else {
ap_log_rerror(APLOG_MARK, APLOG_ERR | APLOG_NOERRNO | APLOG_STARTUP,
0, ctx->r, "%s", msg);
ap_log_rerror(APLOG_MARK, APLOG_ERR | APLOG_STARTUP, 0, ctx->r, "%s", msg);
}
}

static void php_apache_sapi_log_message_ex(char *msg, request_rec *r)
{
if (r) {
ap_log_rerror(APLOG_MARK, APLOG_ERR | APLOG_STARTUP, 0, r, msg, r->filename);
} else {
php_apache_sapi_log_message(msg);
}
}

Expand Down Expand Up @@ -481,14 +488,14 @@ static int php_handler(request_rec *r)
}

if (r->finfo.filetype == 0) {
php_apache_sapi_log_message("script not found or unable to stat");
php_apache_sapi_log_message_ex("script '%s' not found or unable to stat", r);
zend_try {
zend_ini_deactivate(TSRMLS_C);
} zend_end_try();
return HTTP_NOT_FOUND;
}
if (r->finfo.filetype == APR_DIR) {
php_apache_sapi_log_message("attempt to invoke directory as script");
php_apache_sapi_log_message_ex("attempt to invoke directory '%s' as script", r);
zend_try {
zend_ini_deactivate(TSRMLS_C);
} zend_end_try();
Expand Down

0 comments on commit 39baa27

Please sign in to comment.