Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Deprecate implicit nullable parameter types #12959

Merged
merged 1 commit into from Mar 13, 2024

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Dec 15, 2023

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still drafting the RFC

Zend/tests/type_declarations/scalar_none.phpt Show resolved Hide resolved
Zend/tests/type_declarations/scalar_null.phpt Outdated Show resolved Hide resolved
ext/reflection/tests/ReflectionClass_export_basic1.phpt Outdated Show resolved Hide resolved
ext/reflection/tests/parameters_002.phpt Outdated Show resolved Hide resolved
Zend/zend_compile.c Outdated Show resolved Hide resolved
@kocsismate kocsismate force-pushed the deprecate-implicit-nullability branch from 0c855aa to 0248ab9 Compare March 13, 2024 20:39
@kocsismate kocsismate merged commit 330cc5c into php:master Mar 13, 2024
7 of 10 checks passed
@kocsismate kocsismate deleted the deprecate-implicit-nullability branch March 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants