Skip to content

[RFC] Deprecate implicit nullable parameter types - #12959

Merged
kocsismate merged 1 commit into
php:masterfrom
kocsismate:deprecate-implicit-nullability
Mar 13, 2024
Merged

kocsismate merged 1 commit into
php:masterfrom
kocsismate:deprecate-implicit-nullability

Conversation

@kocsismate

@kocsismate kocsismate commented Dec 15, 2023 •

Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still drafting the RFC

Comment thread Zend/tests/type_declarations/scalar_none.phpt Outdated
Comment thread Zend/tests/type_declarations/scalar_null.phpt Outdated
Comment thread Zend/tests/variadic/adding_additional_optional_parameter.phpt Outdated
Comment thread Zend/tests/variadic/adding_additional_optional_parameter_error.phpt Outdated
Comment thread ext/reflection/tests/ReflectionClass_export_basic1.phpt Outdated
Comment thread ext/reflection/tests/parameters_002.phpt Outdated
Comment thread Zend/zend_compile.c Outdated
@kocsismate
kocsismate force-pushed the deprecate-implicit-nullability branch from 8bc9363 to 7ed7137 Compare December 24, 2023 13:16
@kocsismate
kocsismate force-pushed the deprecate-implicit-nullability branch from 7ed7137 to f644467 Compare February 11, 2024 20:53
@kocsismate
kocsismate force-pushed the deprecate-implicit-nullability branch from f644467 to 0c855aa Compare March 13, 2024 19:30
@kocsismate
kocsismate force-pushed the deprecate-implicit-nullability branch from 0c855aa to 0248ab9 Compare March 13, 2024 20:39
@kocsismate
kocsismate merged commit 330cc5c into php:master Mar 13, 2024
@kocsismate
kocsismate deleted the deprecate-implicit-nullability branch March 13, 2024 20:40
shaismithu

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants