ext/curl: Add all missing CURLE constants up to Curl 8.6 #13340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayesh
force-pushed
the
curl-error-consts
branch
2 times, most recently
from
d47b180
to
e46d9d4
Compare
Ayesh
force-pushed
the
curl-error-consts
branch
from
e46d9d4
to
d32d3db
Compare
Ayesh
force-pushed
the
curl-error-consts
branch
3 times, most recently
from
1b8cda1
to
30c0c5d
Compare
Ayesh
force-pushed
the
curl-error-consts
branch
3 times, most recently
from
568a9d9
to
18754c0
Compare
Ayesh
force-pushed
the
curl-error-consts
branch
from
18754c0
to
15d9a53
Compare
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized.
This commit re-arranges all of the CURLE_* constants to a single part of the
curl.stub.phpfile, and rearranges them to match the order of the error constants in the libcurl documentation1.Constants that are deprecated2 are moved shifted to the end of the
CURLE_*constants list.Related: #12000, #13259, #13209, #13282
Footnotes
https://curl.se/libcurl/c/libcurl-errors.html ↩
https://curl.se/libcurl/c/symbols-in-versions.html ↩