ext/curl: Bump minimum Curl version to >= 7.61.0 #13259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
Jan 27, 2024
Girgias
reviewed
Jan 28, 2024
Ayesh
force-pushed
the
libcurl-bump
branch
6 times, most recently
from
41be34e
to
b9f5f0c
Compare
|
Thank you so much @Girgias. You are right, I had missed quite a few version comparisons. I went through the code manually as well as some grepping to catch them, and adjusted accordingly. There are also some code blocks that we remove entirely now. I also added comments to missing preprocess statements without the human-friendly version name in them. |
Girgias
reviewed
Jan 29, 2024
ext/curl/curl.stub.php
Outdated
|
|
||
| #if LIBCURL_VERSION_NUM >= 0x072a00 /* Available since 7.42.0 */ | ||
| /* Available since 7.42.0 */ |
There was a problem hiding this comment.
Should you not remove the version availability? As in some cases you remove in others you keep them
There was a problem hiding this comment.
Thanks for noticing them, should have indeed removed them. I pushed with the entire #if LIBCURL... lines removed including the comments. For Versions >= 7.61, we still keep them. There are some leftover comments like /* Available since 7.10.6 */, not sure if we can clean them up at the same go, but I thought not to do it yet to keep the PR easier to (hopefully) merge. If you think we can clean everything up, I'll happily change them too.
Ayesh
changed the title
Ayesh
force-pushed
the
libcurl-bump
branch
2 times, most recently
from
ee858fe
to
5811828
Compare
Girgias
approved these changes
Jan 31, 2024
|
Thank you so much @Girgias. I added the |
Bumps the minimum required libcurl version to 7.61.0. Please also see php#4917, which bumped minimum libcurl version to the current >= 7.29.0. This bumps the minimum requirement to Curl 7.61.0 (released 2018 Sept). Ubuntu, Debian, RHEL, and RHEL derivatives have major and LTS version bumps this year. Following are the libcurl-dev/libcurl-devel versions available in the oldest supported (LTS or otherwise) in major OSs. - Debian buster: [7.64](https://packages.debian.org/buster/libcurl4-openssl-dev) - Ubuntu 20.04: [7.68](https://packages.ubuntu.com/focal/libcurl-dev) - CentOS/RHEL 7: 7.29 - RHEL 8/Rocky 8/EL 8: 7.61 - Fedora 38: 7.87 RHEL/CentOS 7 reaches EOL mid 2024, so for PHP 8.4 scheduled towards the end of this year, we can safely bump the minimum libcurl version. 7.61.0 was selected as the new minimum because RHEL and derivatives have libcurl-devel version 7.61. RHEL 8 is a current and supported RHEL version.
…n-friendly version names Adds missing human-friendly version number comments where missing.
Girgias
approved these changes
Jan 31, 2024
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. 1: https://curl.se/libcurl/c/libcurl-errors.html 2: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 7, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 7, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Feb 7, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 11, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 12, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 16, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 19, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Mar 19, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
Apr 10, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 6, 2024
ext/curl now requires libcurl 7.61.0, which means a lot of CURL* constants can be re-organized. This commit re-arranges all of the CURLE_* constants to a single part of the `curl.stub.php` file, and rearranges them to match the order of the error constants in the libcurl documentation[^1]. Constants that are deprecated[^2] are moved shifted to the end of the `CURLE_*` constants list. [^1]: https://curl.se/libcurl/c/libcurl-errors.html [^2]: https://curl.se/libcurl/c/symbols-in-versions.html Related: php#12000, php#13259, php#13209, php#13282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the minimum required libcurl version to 7.61.0.
Please also see #4917, which bumped minimum libcurl version to the current >= 7.29.0.
Ubuntu, Debian, RHEL, and RHEL derivatives have major and LTS version bumps this year. Following are the libcurl-dev/libcurl-devel versions available in the oldest supported (LTS or otherwise) in major OSs.
RHEL/CentOS 7 reaches EOL mid 2024, so for PHP 8.4 scheduled towards the end of this year, we can safely bump the minimum libcurl version.
7.61.0 was selected as the new minimum because RHEL and derivatives have libcurl-devel version 7.61. RHEL 8 is a current and supported RHEL version.