test to function openssl_pkcs12_export

[marcosptf]

Was create a new test to function openssl_pkcs12_export;

I would like to say, that in official doc, don't have explain to function argument number 5, "args", to undertand what is work, i need to do many debugs and read the comments from docs.

Thanks

[marcosptf]

http://php.net/manual/en/function.openssl-pkcs12-export.php

[jerrygrey]

@marcosptf --CLEAN-- is missing and...

$priv_key_file_pem = "file://" . dirname(__FILE__) . "/{$key_file}";
$priv_key_dir_pem = __DIR__ . "/{$pem_file}";

Should be...

$priv_key_file_pem = 'file://' . __DIR__ . DIRECTORY_SEPARATOR . $key_file;
$priv_key_dir_pem = __DIR__ . DIRECTORY_SEPARATOR . $pem_file;

Also, why are the files used named "bug37820"? It seems quite confusing.

[marcosptf]

Hi @jerrygrey G-Morning!!!
here in Brazil, is a new day
:-)

lets go to the facts:
1)i can't use this way, because in docs official php, recomend use protocol file://
$priv_key_file_pem = DIR . DIRECTORY_SEPARATOR . $key_file;

2)i've trying use like your said, but the test have failed:

3)i'm using the file bug37820key.pem to test, because it is used in another test and too to my
don't need create another one.

4)please, give me one example, how i can use tag --CLEAN-- on this test, because, i don't see how can i use this tag here

Thanks

[jerrygrey]

@marcosptf Fair enough, but I don't think relying on other test files is a good idea, as those files may change or be removed in the future. Tbh, I don't know why they are there in the first place.

I have updated my code above, but I meant the code should be consistent, switching between __DIR__ and dirname(__FILE__) is not best practice as both are exactly the same.

Also, as pointed out by @bukka here #1601, use tabs instead of spaces for indentations.

[marcosptf]

@jerrygrey
i've fixed like your updated your code above!

:-)

[bukka]

The same as #1595 - I'm going to do a different tests for this

[marcosptf]

👍

[krakjoe]

@marcosptf @bukka can we get an update here please ?

[bukka]

Same as other PR's, please close it.