Skip to content

Conversation

@marcosptf
Copy link
Contributor

I would like to say, that in official doc, don't have explain to function argument number 5, "args", to undertand what is work, i need to do many debugs and read the comments from docs.

Thanks

I would like to say, that in official doc, don't have explain to function argument number 5, "args", to undertand what is work, i need to do many debugs and read the comments from docs.

Thanks
@marcosptf
Copy link
Contributor Author

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't there is any functions that would throw exception so this is useless

@marcosptf
Copy link
Contributor Author

@bukka
fix done!

@jerrygrey
Copy link

@marcosptf There are tons of errors in the code, you should test before making the pull request.

@marcosptf
Copy link
Contributor Author

fix done!
thanks!

@jerrygrey
Copy link

@marcosptf Errors still remain, see #1594.

@marcosptf
Copy link
Contributor Author

@jerrygrey
see my answer there!

@bukka
Copy link
Member

bukka commented Oct 27, 2015

I plan to come up with a different tests for PKCS12 later. There is some missing bits here that should be tested as well. When I was playing with that, I got one mem leak that I need to look at as well. There also is one open bug so I would like to do all of that together and fix it all later. Anyway thanks for the test report. I will close this once all is done. Cheers

@marcosptf
Copy link
Contributor Author

👍

@krakjoe
Copy link
Member

krakjoe commented Jan 6, 2017

@marcosptf @bukka can we get an update here please ?

@bukka
Copy link
Member

bukka commented Jan 6, 2017

I think we can close it. I will come up with different kind of tests once I have time for PKCS12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants