-
Notifications
You must be signed in to change notification settings - Fork 8k
test to function openssl_pkcs12_export_to_file(); #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would like to say, that in official doc, don't have explain to function argument number 5, "args", to undertand what is work, i need to do many debugs and read the comments from docs. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't there is any functions that would throw exception so this is useless
|
@bukka |
|
@marcosptf There are tons of errors in the code, you should test before making the pull request. |
|
fix done! |
|
@marcosptf Errors still remain, see #1594. |
|
@jerrygrey |
|
I plan to come up with a different tests for PKCS12 later. There is some missing bits here that should be tested as well. When I was playing with that, I got one mem leak that I need to look at as well. There also is one open bug so I would like to do all of that together and fix it all later. Anyway thanks for the test report. I will close this once all is done. Cheers |
|
👍 |
|
@marcosptf @bukka can we get an update here please ? |
|
I think we can close it. I will come up with different kind of tests once I have time for PKCS12. |
I would like to say, that in official doc, don't have explain to function argument number 5, "args", to undertand what is work, i need to do many debugs and read the comments from docs.
Thanks