Bugfix for #73987 #2342
Closed
Bugfix for #73987 #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Jan 27, 2017
|
|
||
| ?> | ||
| --EXPECTF-- | ||
| Fatal error: Declaration of B::example($a, $b, $c = NULL) must be compatible with A::example($a, $b = NULL, $c = NULL) in %s |
There was a problem hiding this comment.
IIRC the rule is that an incompatibility with an interface throws a fatal error, while an incompatibility with a (non-abstract) class signature only generates a warning. As such, shouldn't this be a warning? (Same for the other cases as well, of course).
There was a problem hiding this comment.
Nevermind, just saw that we always fatal for return types. In that case it's fine.
nikic
approved these changes
Jan 27, 2017
|
Thanks for the review! Agreed |
|
Merged b67eb34 Thanks. |
eXtreme
added a commit
to eXtreme/flysystem-cached-adapter
that referenced
this pull request
Jun 5, 2018
See the reason: https://3v4l.org/VDT0P The behavior was changed with this PR: php/php-src#2342 but somehow got left undocumented in upgrade file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inheritance checks should not ignore parents if these implement an interface or abstract.
Link for bugsnet: https://bugs.php.net/bug.php?id=73987