Add net_get_interfaces()

[sgolemon]

New function for enumerating network adapters on the local machine.

This favor's windows' format in the normalized output since it provides more info, and groups addresses on single interfaces together.

Output example for windows and linux here:
https://twitter.com/SaraMG/status/933821878510211072

[KalleZ]

This is missing PHPAPI as you have declared in the header

[weltling]

Normally the first declaration is decisive, but would be cleaner to repeat same, yep.

Thanks.

[sgolemon]

As @weltling stated, not needed at point of definition when the included declaration has it, but sure, hurts nothing to add it.

[KalleZ]

Think this is missing FREE(pAddresses) before the return

[sgolemon]

👍

[KalleZ]

(For any other readers)

This implements FR #17400: https://bugs.php.net/bug.php?id=17400

[KalleZ]

@weltling tho we only use iphlpapi here, wouldn't you think its better put in toolset_setup_common_libs() in win32/confutils.js, ext/standard can't be disabled anyway

[weltling]

@KalleZ would work as well, but shouldn't be necessary. $(LIBS) is put for every binary unit, whereby iphlpapi.lib is only required for standard. The linker will ignore it anyway, if there are no symbols used.

[sgolemon]

It sounds like six of one, half a dozen of the other. I honestly don't mind either way, but I read @weltling's comment (and @KalleZ's 👍) as "don't bother moving it. Correct me if that's wrong.

[KalleZ]

This should have a ZEND_PARSE_PARAMETERS_NONE

[sgolemon]

Nice catch.

[winks]

Per my comments on internals, just tested this on FreeBSD 11.1-RELEASE (after a plain ./configure)

Warning: Use of undefined constant AF_INET - assumed 'AF_INET' (this will throw an Error in a future version of PHP) in /tmp/test.php on line 11
bool(false)
array(2) {
  ["vtnet0"]=>
  array(1) {
    ["unicast"]=>
    array(4) {
      [0]=>
      array(2) {
        ["flags"]=>
        int(34883)
        ["family"]=>
        int(18)
      }
      [1]=>
      array(5) {
        ["flags"]=>
        int(34883)
        ["family"]=>
        int(2)
        ["address"]=>
        string(15) "207.154.243.135"
        ["netmask"]=>
        string(13) "255.255.240.0"
        ["broadcast"]=>
        string(15) "207.154.255.255"
      }
      [2]=>
      array(4) {
        ["flags"]=>
        int(34883)
        ["family"]=>
        int(28)
        ["address"]=>
        string(25) "fe80::2c1c:f1ff:fec7:8400"
        ["netmask"]=>
        string(21) "ffff:ffff:ffff:ffff::"
      }
      [3]=>
      array(5) {
        ["flags"]=>
        int(34883)
        ["family"]=>
        int(2)
        ["address"]=>
        string(9) "10.19.0.5"
        ["netmask"]=>
        string(11) "255.255.0.0"
        ["broadcast"]=>
        string(13) "10.19.255.255"
      }
    }
  }
  ["lo0"]=>
  array(1) {
    ["unicast"]=>
    array(4) {
      [0]=>
      array(2) {
        ["flags"]=>
        int(32841)
        ["family"]=>
        int(18)
      }
      [1]=>
      array(4) {
        ["flags"]=>
        int(32841)
        ["family"]=>
        int(28)
        ["address"]=>
        string(3) "::1"
        ["netmask"]=>
        string(39) "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff"
      }
      [2]=>
      array(4) {
        ["flags"]=>
        int(32841)
        ["family"]=>
        int(28)
        ["address"]=>
        string(7) "fe80::1"
        ["netmask"]=>
        string(21) "ffff:ffff:ffff:ffff::"
      }
      [3]=>
      array(4) {
        ["flags"]=>
        int(32841)
        ["family"]=>
        int(2)
        ["address"]=>
        string(9) "127.0.0.1"
        ["netmask"]=>
        string(9) "255.0.0.0"
      }
    }
  }
}

```

[sgolemon]

@winks Ah, hrmm. Well, that's the implementation working, but the unittest failing because AF_INET is defined by the sockets extension which isn't always enabled. Nice catch.

[sgolemon]

Committed to 7.3 as 7ca5a7d

[KalleZ]

@sgolemon we do have STREAM_PF_INET which is either PF_INET or AF_INET depending on what constant was available at compile time in the core

[remicollet]

@sgolemon woulnd't it makes sense to expose a few constants from if.h to be able to analyse the "flags".

Can even be nice to be able to filter according to it:
$interfaces = net_get_interfaces(IFF_UP & IFF_RUNNING);
(even if this can be trivially done in php lang)

[remicollet]

so pr #2948

[cubiclesoft]

This function is buggy, undocumented, and several opportunities were missed. See:

https://bugs.php.net/bug.php?id=79251

I see that no one noticed the obvious "unicast" array bug during the initial implementation despite one sample output above clearly showing the problem on this PR's thread. That is, AF_PACKET (17) and AF_LINK (18) families have MAC addresses, not IP addresses. As a result, the first entry in each interface's "unicast" array is missing its associated information.