Add AS_HELP_STRING to *nix build configure options #3910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Autoconf's default AS_HELP_STRING macro can properly format help strings [1] so watching out if columns are aligned manually is not anymore. [1] https://www.gnu.org/software/autoconf/manual/autoconf.html#Pretty-Help-Strings
- Refactor remaining options - Refactor help string for PDO ODBC - Refactor example in README
|
Is the use of quadrigraphs necessary if our |
No, I guess these are really not needed anymore in this particular case... I think that recent Autoconf versions (PHP requires now 2.68) have this fixed a bit, so the next commit omits the quadrigraphs now. |
nikic
approved these changes
Mar 7, 2019
|
Applied via 9df6a1e to PHP-7.4+ |
|
@petk Thanks for your amazing work on cleanup some stuff ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Autoconf's default
AS_HELP_STRINGmacro can properly format help strings [1] so watching out if columns are aligned manually won't be needed anymore.These strings are visible in the
configure --helpoutput.TODO:
configure.ac