Fix bug #65028 #392

Merged
merged 1 commit into from Jul 24, 2013

Conversation

Projects
None yet
5 participants
Contributor

smalyshev commented Jul 22, 2013

Fix bug #65028: Phar::buildFromDirectory creates corrupt archives for so...me specific contents.

Somewhat hackish solution - see https://bugs.php.net/bug.php?id=65028 for the description of the bug and suspected cause.

Contributor

weltling commented Jul 23, 2013

I can reproduce this in master, despite this patch is built upon 5.4. The fix works, tests pass on windows/linux

Contributor

weltling commented Jul 23, 2013

Maybe one improvement though, at the end of the test one could list the files in the copied phar and compare to the original. I've used RecursiveIteratorIterator to do that.

+ "style/Fusonic/40components.css",
+ "style/_emptyDirectory",
+ "index.php",
+// "a", // This will make the test pass
@johannes

johannes Jul 23, 2013

Owner

Assuming that the test passes after fixing the issue this comment is misleading ;-)

@smalyshev

smalyshev Aug 6, 2013

Contributor

Yes, it should pass anyway, I just copied the test directly from the bug and forgot to remove the comment

@php-pulls php-pulls merged commit f8efdc2 into php:PHP-5.4 Jul 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment