New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify scratch register in SAVE_VALID_OPLINE #5270

Closed

nikic wants to merge 2 commits into php:master from nikic:save-valid-opline

Member

nikic commented Mar 18, 2020

And use r1 instead of r0 inside read_obj.

nikic added 2 commits

March 18, 2020 09:57


          Pass scratch register to SAVE_VALID_OPLINE

ff59dd5


          Use different scratch register in read_obj

1875c84

We already use r0 to hold the zval.

Member

dstogov commented Mar 18, 2020

Looks fine!

Member Author

nikic commented Mar 18, 2020

Merged as 6993787, 70ef2f3.

nikic closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet