Declare tentative return types in ext/spl - part 3

[kocsismate]

No description provided.

[jrfnl]

Help! It may just be me being stupid and doing something wrong, but adding the attribute to methods implementing the Iterator interfaces does not seem to work. I've done similar PRs elsewhere for other interfaces already and they all fixed the issues, but not for the Iterators.

Please do let me know if you'd rather I open a bug report at bugs.php.net.

This is where the issue can be seen:

• Build against PHP 8.1-nightly without the attributes - note: you need to fold out the "PHPCS: check code style without cache, no parallel" step to see the issue: https://github.com/jrfnl/PHP_CodeSniffer/runs/3143199357
• Commit adding the attributes: jrfnl/PHP_CodeSniffer@4553cbf
• Build against PHP 8.1-nightly with the attributes: https://github.com/jrfnl/PHP_CodeSniffer/runs/3143286550

[nikic]

@jrfnl I think your patch is just missing a use / FQCN.

[kamil-tekiela]

@jrfnl I think it'd be best if you file a proper bug report on bugs.php.net. A comment here might get lost or forgotten.

[jrfnl]

@jrfnl I think your patch is just missing a use / FQCN.

Cricky! Of course... Duh! Trying to think back now, but yes, I think the other patches I submitted for these types of things were all in non-namespaced projects ;-)

(Yeah, don't get me started, but that's another issue)

[jrfnl]

Confirmed: adding the use statement fixed it. Just a Friday afternoon blond moment. Thanks @nikic !