Fix #66588: SplFileObject::fgetcsv incorrectly returns a row on premature EOF. #7535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture EOF. This bug is about the different behavior with and without trailing newline.
|
We discussed this behavior some time ago (cc @cmb69), but I don't think we really reached a conclusion on what to do with it. I'm inclined to accept to accept this, as the current distinction really doesn't make sense to me. I'd go for PHP-8.1 only though -- even as a bug fix, this is a subtle behavior change, and as such risky for released versions. |
cmb69
reviewed
Sep 30, 2021
| } | ||
| zend_array_destroy(Z_ARR_P(return_value)); | ||
| RETVAL_FALSE; | ||
| goto quit_loop_2; | ||
| goto out; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug is about the different behavior with and without trailing newline.