Added: [zend_]memory_reset_peak_usage() #8151
Conversation
|
Looks like a very reasonable addition to me! |
|
Does it require any more review/discussion/RFC so that I can commit this? |
patrickallaert
force-pushed
the
zend_memory_reset_peak_usage
branch
from
5b24c1e
to
7a2425e
Compare
| @@ -2175,6 +2175,9 @@ ZEND_END_ARG_INFO() | |||
|
|
|||
| #define arginfo_memory_get_peak_usage arginfo_memory_get_usage | |||
|
|
|||
| ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_memory_reset_peak_usage, 0, 0, IS_VOID, 0) | |||
There was a problem hiding this comment.
This change looks suspicious to me: the stub file from which this file is generated is not modified. I suspect that this was changed manually instead of being generated, which would then be lost on next run of the generator.
There was a problem hiding this comment.
And you were so right! I'm going to fix this.
There was a problem hiding this comment.
can git add . -N && git diff --exit-code be added to CI to check if all generated files are in sync after build is run?
There was a problem hiding this comment.
That would make sense. Would also prevent adding malicious code to generated files like zend_vm_execute.h.
No description provided.