Fix run-tests.php for explicitly given test cases #9617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent improvement to list skipped extensions explicitly[1] missed to properly initialize `$ignored_by_ext` for the case where an explicit set of test cases are given; this was not a problem previously, since the undefined *global* variable was coerced to int. We fix this by initializing the variable earlier. [1] <php@baef47e>
|
Thank you Christoph! |
|
Thank you, Ilija! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent improvement to list skipped extensions explicitly[1] missed to properly initialize
$ignored_by_extfor the case where an explicit set of test cases are given; this was not a problem previously, since the undefined global variable was coerced to int. We fix this by initializing the variable earlier.[1] baef47e