Fix bug #68207: Setting fastcgi.error_header can result in a WARNING #9980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the original issue has been fixed already as FPM doesn't send headers before the request end so it is still possible to change header line in the reported example. However there is still an edge case when the warning is emitted if there is an error after calling
fastcgi_finish_request(). The message has got also a wrong script and line as it come from FPM so it is unknown. The PR adds a check for sent headers and does not try to change it which makes more sense for sure.The actual change is really small but the main work was to extend tester to allow testing of no pattern match. I also added slightly unrelated extension in the tester for the log entries which is not used here but it's consistent and possibly useful in the future.