Vertically center search box #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
reviewed
Mar 29, 2018
| @@ -182,7 +182,7 @@ textarea { | |||
| .navbar-search { | |||
| position: relative; | |||
| float: left; | |||
| margin-top: .625rem; | |||
| margin-top: .770rem; | |||
There was a problem hiding this comment.
It would be better to use a vertical centring technique, instead of arbitrarily adjusting one margin, to ensure consistency across all devices and screen sizes.
There was a problem hiding this comment.
@Bilge is there a place one can view browser stats for php.net so we know the most recent method we could use?
|
Comment on behalf of petk at php.net: Thank @jesobreira for your contribution. Applied via d26b9a7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if it's my OCD but this was taking my attention every time I visited php.net:
This very small PR moves the search field closer to the middle.