CS update after upstream changes #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix the name and description to prevent confusion between the project ruleset and the organisation ruleset. * Set the minimum PHP version for the PHPCompatibility standard. * Don't require property type declarations. * Ensure special characters used as literals in an exclude pattern are escaped.
|
The build failure is unrelated to this PR. See my other PRs. Happy to rebase after those have been merged. |
|
These changes look good to me. I need to have a look at the psalm failures. But this one is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPCS ruleset: update ruleset for upstream changes
CS: no whitespace before return type colon
CS: blank line between different use statement types
CS: miscellaneous other whitespace fixes