Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve new 'default' template #2393

Open
5 of 10 tasks
mvriel opened this issue Jun 13, 2020 · 4 comments
Open
5 of 10 tasks

Improve new 'default' template #2393

mvriel opened this issue Jun 13, 2020 · 4 comments

Comments

@mvriel
Copy link
Member

mvriel commented Jun 13, 2020

I have created this issue to track and write down my progress on the new 'default' template. This description will change with every iteration and will reflect the latest finds and points of improvement.

TODO:

  • Table of Contents, and the method/property/constant listing, is not sorted by visibility and alphabet
  • Change the grid's selectors to match the CSS standards
  • Document the shit out of the new template and specifically: how to surgically alter it to your needs
  • Describe the CSS standards for future contributors
  • Test
  • When an element overrides an inherited version, add a link to the inherited version in the element's description
  • I think I saw a tag header shown, even though there are no tags; check this
  • check source code inclusion, references and styling
  • Research pushing NPM package with CSS, see https://help.github.com/en/actions/language-and-framework-guides/publishing-nodejs-packages
  • Write tests for changes in the Extension class
@mvriel mvriel added this to the 3.0.0 milestone Jun 13, 2020
@mvriel mvriel self-assigned this Jun 13, 2020
@jaapio jaapio added this to Needs triage in phpDoc issue triage board Jun 13, 2020
@jrfnl
Copy link
Contributor

jrfnl commented Jun 16, 2020

Some small things which I noticed in the template:

Markdown table layout off

Minimal code sample:

    /**
     * Summary.
     *
     * Unkeyed arrays | Keyed arrays
     * -------------- | ------------
     * processNoKey() | processKey()
     * -              | processArrow()
     * processValue() | processValue()
     * processComma() | processComma()
     */
    function foo() {}

Originally found in: https://github.com/PHPCSStandards/PHPCSUtils/blob/7a54196a2c079dae38d2bd5b5eb605f514d9c3e6/PHPCSUtils/AbstractSniffs/AbstractArrayDeclarationSniff.php#L209-L233

Result:

phpdoc-table-display

@jrfnl
Copy link
Contributor

jrfnl commented Jun 16, 2020

Some small things which I noticed in the template:

Inline code with non-code in between loses spacing

Minimal code sample:

    /**
     * Summary.
     *
     * - References to class properties with `self::`, `parent::`, `static::`,
     *  `namespace\ClassName::`, `classname::` were not recognized as references.
     */
    function foo() {}

Originally found in: https://github.com/PHPCSStandards/PHPCSUtils/blob/7a54196a2c079dae38d2bd5b5eb605f514d9c3e6/PHPCSUtils/BackCompat/BCFile.php#L963-L991

Result:

phpdoc-spacing-code-elms

jrfnl added a commit to jrfnl/phpDocumentor-issue-demo that referenced this issue Jun 17, 2020
@jrfnl
Copy link
Contributor

jrfnl commented Jun 17, 2020

Some small things which I noticed in the template:

The "Project name" doesn't link to the docs index.html file

... which means that once you've left the index.html file, there is no way to get back to it anymore as there is no link to it anywhere.

image

@mvriel
Copy link
Member Author

mvriel commented Jun 17, 2020

👍 Thanks!

mvriel added a commit that referenced this issue Jun 19, 2020
- Sort constants, methods and properties on visibility and alphabet
  - In TOC
  - In List of elements
- Extract Description and Summary to loose templates
- Add a link around the header, and style it
- Show a read-only indicator with properties
- Show a write-only indicator with properties
- Do not show property(-*) tag in tag listing
- Do not show method tag in tag listing

Fixes #2439 and #2438

Addresses points in #2393
@jaapio jaapio added this to Backlog in v3.2 via automation Nov 6, 2020
@jaapio jaapio removed this from Needs triage in phpDoc issue triage board Nov 6, 2020
@jaapio jaapio added this to To do in v3.4 Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v3.2
Backlog
v3.4
Backlog
Development

No branches or pull requests

2 participants