Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Tags" sections are anchored back to overview page #3042

Closed
Xymph opened this issue Oct 11, 2021 · 2 comments · Fixed by #3404
Closed

"Tags" sections are anchored back to overview page #3042

Xymph opened this issue Oct 11, 2021 · 2 comments · Fixed by #3404

Comments

@Xymph
Copy link

Xymph commented Oct 11, 2021

When a docblock contains a @link tag, a "Tags" section is generated with that link entry and its URL. The section header itself is anchored to <project_path>/#tags which is not defined on that project overview page.
(Hope this is not another existing issue/PR.)

Expected behavior

Anchor to something meaningful, or don't anchor.

Actual behavior

See intro. Example in $maxlag section in first screenshot of #3039. I'm not sure what the intended purpose of /#tags currently is.

Steps to reproduce the problem

phpDocumentor.phar run -v --title=Wikimate -d . -i examples.php --sourcecode -t <path_to_my_private_site> -s graphs.enabled=true

Your environment

  • Version used: 3.1.2
  • Install method: downloaded PHAR
  • PHP version: 7.4
  • Operating system and version: Ubuntu 20.04 LTS
  • Link to your project: https://github.com/hamstar/Wikimate
mvriel added a commit that referenced this issue Dec 8, 2022
To fix #3042 and embrace components in the default template, I have
moved the deep link anchors (headerlinks) onto a component and as such
fix all locations where they were used. Apparently I missed the tags
headerlink in the previous fix
@mvriel
Copy link
Member

mvriel commented Dec 8, 2022

Last week, I thought I had fixed all these links; but just to be sure I checked your report. And apparently, I had still missed that. Thus I just issued PR #3404 to fix this and move the anchors onto a component so that others may more easily re-style them if needed.

Thank you for your report and this will be fixed as soon as the PR is approved and merged

@mvriel mvriel closed this as completed Dec 8, 2022
@mvriel
Copy link
Member

mvriel commented Dec 8, 2022

Oh, and I closed the issue perhaps a bit prematurely.. oh well, I'm very sure it will land quite soon :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants