Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug on scrutinizer. #1414

Closed
wants to merge 2 commits into from
Closed

Conversation

minkbear
Copy link
Contributor

Fixed bug. The property ... does not exist. Since you implemented __get, maybe consider adding a @Property annotation.

@mvriel
Copy link
Member

mvriel commented Sep 1, 2014

The descriptor collection object is used in several locations of which most do not have these elements that you describe in these @property tags

@minkbear
Copy link
Contributor Author

minkbear commented Sep 1, 2014

@mvriel
Copy link
Member

mvriel commented Sep 19, 2014

This can only be fixed by exchanging the property accessor (->) with the actual getter or using array notation; or by introducing a new Collection class specific to the indices (though the indices are meant to be flexible).

Because the contents of this PR are not mergeable I will close this PR; please re-submit the PR if you would like to help us out some more with a new change

@mvriel mvriel closed this Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants