Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitattributes: do not export tests [closes #1529] #1564

Merged
merged 1 commit into from May 24, 2015
Merged

gitattributes: do not export tests [closes #1529] #1564

merged 1 commit into from May 24, 2015

Conversation

TomasVotruba
Copy link
Contributor

Tests are not needed by composer.

@mvriel
Copy link
Member

mvriel commented May 24, 2015

Hi @TomasVotruba, thanks for this PR! Do you think you can exclude the features folder folder as well? That's the one with the huge file names because of the Behat features. Thank you!

@TomasVotruba
Copy link
Contributor Author

@mvriel Sure. While we're at it, all these are not used by composer, so I'd exclude them as well:

  • /ansible
  • /docs
  • /features
  • /tests
  • .gitattributes
  • .gitignore
  • .scrutinizer.yml
  • .travis.yml
  • CHANGELOG.md
  • CONTRIBUTING.md
  • README.md
  • Vagrantfile
  • behat.yml
  • box.json
  • build.xml
  • package.xml
  • phpdoc.dist.xml
  • phpmd.xml.dist
  • phpunit.xml.dist
  • wercker.yml

@mvriel
Copy link
Member

mvriel commented May 24, 2015

IIRC is .gitattributes and .gitignore used by composer because composer does git clones when you prefer-source it; the VERSION file is required for the correct functioning of phpDocumentor; I also don't know how composer will react when the composer.json and lock file are excluded in this way

@mvriel
Copy link
Member

mvriel commented May 24, 2015

The rest does indeed look redundant for a composer installation

@TomasVotruba
Copy link
Contributor Author

Sorry, I forgot to remove composer.* while copying. They shall be kept.

.gitattributes and .gitignore can be left out with no problem. I'm using it in many repo, Doctrine too etc.

I've updated the list above.

@mvriel
Copy link
Member

mvriel commented May 24, 2015

Looks like a perfect list 👍

@TomasVotruba
Copy link
Contributor Author

It's up!

mvriel added a commit that referenced this pull request May 24, 2015
gitattributes: do not export tests [closes #1529]
@mvriel mvriel merged commit 49f78e5 into phpDocumentor:develop May 24, 2015
@mvriel
Copy link
Member

mvriel commented May 24, 2015

👍

@mvriel
Copy link
Member

mvriel commented May 24, 2015

This commit needs to be cherry-picked to the master branch as well because that is where the phpDocumentor 2.8.* release is (develop is phpDocumentor 3); I can do that tomorrow (I am in the midst of a refactoring that I'd rather not stash now :) )

@TomasVotruba
Copy link
Contributor Author

👍

@TomasVotruba TomasVotruba deleted the patch-1 branch May 25, 2015 06:40
@ross-p
Copy link

ross-p commented Jun 3, 2015

@mvriel Any update on this? I'm having this problem on Win 8.1 x64 on a phpdoc 2.8.2 that I pulled today. Thanks :)

@mvriel
Copy link
Member

mvriel commented Jun 15, 2015

Apparently this task slipped my mind; I have just cherry-picked this to master and tagged 2.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants