New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitattributes: do not export tests [closes #1529] #1564
Conversation
Hi @TomasVotruba, thanks for this PR! Do you think you can exclude the |
@mvriel Sure. While we're at it, all these are not used by composer, so I'd exclude them as well:
|
IIRC is .gitattributes and .gitignore used by composer because composer does git clones when you prefer-source it; the VERSION file is required for the correct functioning of phpDocumentor; I also don't know how composer will react when the composer.json and lock file are excluded in this way |
The rest does indeed look redundant for a composer installation |
Sorry, I forgot to remove
I've updated the list above. |
Looks like a perfect list 👍 |
It's up! |
gitattributes: do not export tests [closes #1529]
👍 |
This commit needs to be cherry-picked to the master branch as well because that is where the phpDocumentor 2.8.* release is (develop is phpDocumentor 3); I can do that tomorrow (I am in the midst of a refactoring that I'd rather not stash now :) ) |
👍 |
@mvriel Any update on this? I'm having this problem on Win 8.1 x64 on a phpdoc 2.8.2 that I pulled today. Thanks :) |
Apparently this task slipped my mind; I have just cherry-picked this to master and tagged 2.8.3 |
Tests are not needed by composer.