Restore functionality of the 'replace' directive #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process of splitting the parsing from the rendering, we did not take into account that variables were stored on the Environment class. In the original implementation this Environment class shared state between just about everything in the whole app. By pushing the variables into the DocumentDescriptor and restoring it when rendering, the replace functionality now works again. Additionally, I found a slight bug in the DocumentParser; when a Directive is followed by something other than a CodeNode we want to ignore it and not pass it as a SpanNode to the directive's process function. In that scenario, the deeper business logic will convert that SpanNode into a piece of text on the page. Which you do not want.
jaapio
reviewed
Sep 17, 2021
jaapio
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of splitting the parsing from the rendering, we did not
take into account that variables were stored on the Environment class.
In the original implementation this Environment class shared state
between just about everything in the whole app.
By pushing the variables into the DocumentDescriptor and restoring it
when rendering, the replace functionality now works again.
Additionally, I found a slight bug in the DocumentParser; when a
Directive is followed by something other than a CodeNode we want to
ignore it and not pass it as a SpanNode to the directive's process
function. In that scenario, the deeper business logic will convert that
SpanNode into a piece of text on the page. Which you do not want.
Fixes #3006