Skip to content

Commit

Permalink
Clarified clicks label (#168)
Browse files Browse the repository at this point in the history
* Clarified clicks label

* Added comment clarifying that content is loaded via AJAX (content below is ignored)

* Changed label 'clicks' to more accurate 'unique clicks' ('clicks' is used as a label with inconsistent meaning)
  • Loading branch information
samtuke authored and michield committed Apr 19, 2017
1 parent ba70408 commit 2b5e4b4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion public_html/lists/admin/actions/statsoverview.php
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@

$totalclicked = Sql_Fetch_Row_Query(sprintf('select count(distinct userid) from %s where messageid = %d',
$GLOBALS['tables']['linktrack_uml_click'], $row['messageid']));
$ls->addColumn($element, $GLOBALS['I18N']->get('clicks'), $totalclicked[0],
$ls->addColumn($element, $GLOBALS['I18N']->get('Unique Clicks'), $totalclicked[0],
$totalclicked[0] ? PageURL2('mclicks&id='.$row['messageid']) : '');

$ls->addRow($element, '',
Expand Down
2 changes: 1 addition & 1 deletion public_html/lists/admin/messages.php
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@
<tr><td>' .s('Unique Views').'</td><td>'.$uniqueviews[0].'</td></tr>';
if ($clicks[0]) {
$resultStats .= '
<tr><td>' .s('Clicks').'</td><td>'.$clicks[0].'</td></tr>';
<tr><td>' .s('Total Clicks').'</td><td>'.$clicks[0].'</td></tr>';
}
$resultStats .= '
<tr><td>' .s('Bounced').'</td><td>'.$msg['bouncecount'].'</td></tr>';
Expand Down
1 change: 1 addition & 0 deletions public_html/lists/admin/statsoverview.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
unset($_SESSION['LoadDelay']);
}

// Load page content via AJAX
echo '<div id="contentdiv"></div>';
echo asyncLoadContent('./?page=pageaction&action=statsoverview&ajaxed=true&id='.$id.'&start='.$start.addCsrfGetToken());

Expand Down

0 comments on commit 2b5e4b4

Please sign in to comment.