New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantis 18729 - modifying a subscriber's email address #179

Merged
merged 3 commits into from May 28, 2017

Conversation

Projects
None yet
2 participants
@bramley
Contributor

bramley commented May 25, 2017

This pull request has three commits:

  • add validation that an email address has been entered and does not already exist when changing the email address
  • remove unused variables
  • remove surrounding spaces from the entered email address
@michield

Bit hard to read with so many indentation changes, but the top bit seems fine.

@michield michield merged commit 6ff4cd1 into phpList:master May 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bramley

This comment has been minimized.

Contributor

bramley commented May 28, 2017

That's why I made three commits so that each could be viewed separately. But you can view a diff ignoring whitespace changes by adding &w=1 to the url, e.g.
https://github.com/phpList/phplist3/pull/179/files?diff=split&w=1

@bramley bramley deleted the bramley:Mantis_18729 branch Jun 11, 2017

samtuke added a commit to samtuke/phplist3 that referenced this pull request Nov 21, 2017

Mantis 18729 - modifying a subscriber's email address (phpList#179)
* Add validation that email address has been entered and does not already exist.

* Remove redundant variables and realign indentation.
Remove unnecessary exit() after Redirect().

* Remove surrounding spaces from entered email address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment