Set ownerid of invite campaign to 1 for fresh new installations #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
michield
requested changes
Jul 29, 2018
public_html/lists/admin/lib.php
Outdated
| @@ -1484,7 +1484,7 @@ function addSubscriberStatistics($item, $amount, $list = 0) | |||
| * @todo Make the campaign content translatable | |||
| * @todo Add Campaign Meta Title to clarify purpose of this draft | |||
| */ | |||
| function addInviteCampaign() { | |||
| function addInviteCampaign($install) { | |||
There was a problem hiding this comment.
This param should be initialised to be backwards compatible
function addInviteCampaign($install = "") {
Also, "install" is not a great description of this parameter, but we can live with that.
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
|
@michield thanks for the review. I made changes to the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xheni Myrtaj myrtajxheni@gmail.com