Shortening text that needs to be multibyte aware #877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shortenTextDisplay()
currently returns aspan
element which can be used when displaying URLs or email addresses.This change splits the part of shortening text that needs to be multibyte aware into a separate function so that it can be used on its own to shorten other text, such as an attribute name in a
select
list.It also fixes a few small issues that were introduced in earlier pull requests
sprintf()
with more parameters than %s placeholdersondblclick()
handler which had been removed from the non multibyte versionRelated Issue
The new function
shortenText()
can be used instead ofshortenTextDisplay()
in PR #876Screenshots (if appropriate):