Model won't update if @id column name is different to

[JamesMahy]

Schema

CREATE TABLE `some_table` (
  `id_field` INT(20) NOT NULL AUTO_INCREMENT,
  `value_field` VARCHAR(50) NULL,
  PRIMARY KEY (`id_field`)  
);

Model

namespace models;

/**
 * @table("name"=>"some_table")
 **/
class MyModel
{
	/**
	 * @id
	 * @column("name"=>"id_field")
	 */
	private $idField;
	
	/**
	 * @column("name"=>"value_field")
	 */
	private $valueField;
	
	public function getIdField(){return $this->idField;}
	public function setIdField($id=0){$this->idField = $id;}
	
	public function getValueField(){return $this->valueField;}
	public function setValueField($value){$this->valueField = $value;}	
}

Code

$item = DAO::getOne(MyModel::class, 'id_field = ?', false, [1]);
$item->setValueField('hello');
if(DAO::save(item)){
  echo 'congrats';
}

When i echo out $sql after line 235 of DAOUpdatesTrait.php i get the following sql

UPDATE `some_table` SET `id_field`= :id_field,`value_field`= :value_field WHERE `idField`= :idField

The fields in the where clause should be based on the @column annotation not the variable name!

Thanks

[JamesMahy]

I'm not sure if in the scheme of the framework this is the right solution but changing

public static function getFieldsAndValues_($instance, $members) {
		$ret = [ ];
		foreach ( $members as $member ) {
			$v = Reflexion::getMemberValue ( $instance, $member );
			$ret [$member] = $v;
		}
		return $ret;
	}

to

public static function getFieldsAndValues_($instance, $members) {
		$ret = [ ];
		foreach ( $members as $member ) {
			$k = self::getFieldName(get_class($instance), $member);			
			$v = Reflexion::getMemberValue ( $instance, $member );
			$ret [$k] = $v;
		}
		return $ret;
	}

Solves the issue, however it does mean that if someone wants to update the ID based on an old ID it will fail - not a common use case however

[jcheron]

Thanks @JamesMahy
I just pulled an unnecessarily repeated operation out of the foreach:

ubiquity/src/Ubiquity/orm/OrmUtils.php

Lines 56 to 65 in f9591ed

	public static function getFieldsAndValues_($instance, $members) {
	$ret = [ ];
	$fieldnames = self::getAnnotationInfo ( \get_class ( $instance ), '#fieldNames' );
	foreach ( $members as $member ) {
	$v = Reflexion::getMemberValue ( $instance, $member );
	$ret [$fieldnames [$member] ?? $member] = $v;
	}
	return $ret;
	}

[JamesMahy]

Thanks, looks good!

I tried something similar although without prior understanding of how the framework fits together couldn't make it work