Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing dependencies recursevily #239

Closed
wants to merge 2 commits into from

Conversation

AlessandroMinoccheri
Copy link
Member

In this PR I changed how we parse files with their dependencies.
If we find a dependency, now we check also inside it other dependencies recursively.

Now the collection of ClassDescription has the responsibility to check rules because we need to get all the dependencies of the class to be checked.

@AlessandroMinoccheri AlessandroMinoccheri force-pushed the check-dependencies-recursively branch 3 times, most recently from d0e6634 to 8ebe3fb Compare February 12, 2022 09:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2022

Codecov Report

Merging #239 (537f3dc) into main (efc2ea8) will decrease coverage by 2.90%.
The diff coverage is 81.32%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #239      +/-   ##
============================================
- Coverage     92.99%   90.09%   -2.91%     
- Complexity      315      384      +69     
============================================
  Files            52       54       +2     
  Lines           814      999     +185     
============================================
+ Hits            757      900     +143     
- Misses           57       99      +42     
Impacted Files Coverage Δ
src/Analyzer/FileParser.php 75.26% <75.32%> (-9.92%) ⬇️
src/Analyzer/ClassDescriptionCollection.php 76.56% <76.56%> (ø)
src/Analyzer/FileVisitor.php 85.96% <77.77%> (-2.04%) ⬇️
src/Expression/ForClasses/NotExtend.php 82.35% <83.33%> (-3.37%) ⬇️
src/Analyzer/FileContentGetter.php 84.61% <84.61%> (ø)
src/CLI/Runner.php 94.28% <88.23%> (-1.37%) ⬇️
src/Expression/ForClasses/Extend.php 94.44% <92.85%> (+2.77%) ⬆️
src/Analyzer/ClassDescriptionBuilder.php 88.46% <100.00%> (ø)
src/Analyzer/FileParserFactory.php 100.00% <100.00%> (ø)
...ession/ForClasses/DependsOnlyOnTheseNamespaces.php 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc2ea8...537f3dc. Read the comment docs.

@AlessandroMinoccheri AlessandroMinoccheri force-pushed the check-dependencies-recursively branch 2 times, most recently from d594b98 to 5b57f04 Compare February 12, 2022 11:55
@AlessandroMinoccheri AlessandroMinoccheri changed the title WIP parsing dependencies recursevily Parsing dependencies recursevily Feb 12, 2022
@AlessandroMinoccheri AlessandroMinoccheri force-pushed the check-dependencies-recursively branch 3 times, most recently from 9232206 to c4ddb2f Compare February 14, 2022 07:33
@AlessandroMinoccheri AlessandroMinoccheri force-pushed the check-dependencies-recursively branch 8 times, most recently from 8a20a6f to 6353925 Compare February 20, 2022 08:51
@pfazzi
Copy link
Collaborator

pfazzi commented Sep 2, 2022

La chiudiamo questa? È aperta da tempo immemore... :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants