-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing dependencies recursevily #239
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34b4fe2
to
04dc3aa
Compare
d0e6634
to
8ebe3fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
============================================
- Coverage 92.99% 90.09% -2.91%
- Complexity 315 384 +69
============================================
Files 52 54 +2
Lines 814 999 +185
============================================
+ Hits 757 900 +143
- Misses 57 99 +42
Continue to review full report at Codecov.
|
d594b98
to
5b57f04
Compare
9232206
to
c4ddb2f
Compare
8a20a6f
to
6353925
Compare
6353925
to
073c0cf
Compare
La chiudiamo questa? È aperta da tempo immemore... :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I changed how we parse files with their dependencies.
If we find a dependency, now we check also inside it other dependencies recursively.
Now the collection of ClassDescription has the responsibility to check rules because we need to get all the dependencies of the class to be checked.