Add "Validated for: version #" to download button info #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I highly doubt this will curb what you're intending it to curb, but it doesn't hurt anything either I guess. |
DavidIQ
added a commit
that referenced
this pull request
Dec 3, 2015
Add "Validated for: version #" to download button info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds to the download button info box that appears a little text:
Validated for:
phpBB 3.1.X
There are always people who think the version we display in the download button means that the contribution is ONLY for that version of phpBB. I am hoping this little addition of info makes it clearer that the version of phpBB displayed is not a rule, it's just our way of showing what version of phpBB we used when validating the contrib.