[ticket/11994] Make extension manager UI less misleading #1845
Conversation
| 'EXTENSION_DISABLE_EXPLAIN' => 'Disabling an extension retains its files, data and settings but removes any functionality added by the extension.', | ||
| 'EXTENSION_ENABLE_EXPLAIN' => 'Enabling an extension allows you to use it on your board.', | ||
| 'EXTENSION_INSTALL_EXPLAIN' => 'Installing an extension will perform database changes that are required to use the extension on your board.', | ||
| 'EXTENSION_UNINSTALL_EXPLAIN' => 'Uninstalling an extension removes all data and settings of the extensions. Only the extension files are retained, so you can install it again.', |
There was a problem hiding this comment.
Change "Only the" to "The", remove the comma, and end with so it can be installed again.
|
I haven't tested, but the code looks good. I'll try to remember to test it tonight after work. |
|
Just tested and it looks good. From IRC: |
| 'EXTENSION_DISABLE_EXPLAIN' => 'Disabling an extension retains its files, data and settings but removes any functionality added by the extension.', | ||
| 'EXTENSION_ENABLE_EXPLAIN' => 'Enabling an extension allows you to use it on your board.', | ||
| 'EXTENSION_INSTALL_EXPLAIN' => 'Installing an extension will perform database changes that are required to use the extension on your board.', | ||
| 'EXTENSION_UNINSTALL_EXPLAIN' => 'Uninstalling an extension removes all data and settings of the extensions. The extension files are retained so it can be installed again.', |
There was a problem hiding this comment.
"of the extensions" should probably not be plural here. Actually maybe say, "Uninstalling an extension removes all of its data and settings."
|
Changed the confirmation screens to use the display name rather then vendor/extension |
|
I do not think install/enable should be differentiated in the UI. All the user cares about is that it is working, "Enable" takes care of everything for them. |
|
No, users are confused if they can not install stuff... |
|
I like the change. Install and Uninstall are very commonly used terms in software. Enable and Disable are different than either of those actions, and should be differentiated. |
|
Technically, I would think install means files are being copied into place. For example, Wordpress uses "install" when downloading a plugin or theme from their site and copying its files into your wordpress installation. Then they offer you the "Activate" or "Deactivate" terms to enable/disable. And finally a "Delete" option to remove everything related to it from your installation. I think if phpBB intends to have, at some point, a similar system where Extensions and Styles could possibly be installed directly from the CDB via an interface in the board's ACP, then install and uninstall should be reserved for that purpose. And Enable/Disable should be used for making the extension, well, enabled or disabled. So I like the differentiation too. |
| 'DISABLE_EXPLAIN' => 'Disabling an extension retains its files and settings but removes any functionality added by the extension.', | ||
| 'PURGE_EXPLAIN' => 'Purging an extension clears an extensions data while retaining its files.', | ||
| 'DELETE_EXPLAIN' => 'Deleting an extension removes all of its files and settings. Log entries will remain, although any language variables added by the extension will not be available.', | ||
| 'EXTENSION_DELETE_DATA_EXPLAIN' => 'Deleting data of an extension removes all of its data and settings. The extension files are retained so it can be enabled again.', |
There was a problem hiding this comment.
"Deleting data of an extension" -> "Deleting an extension's data". Should probably also mention that this cannot be undone?
There was a problem hiding this comment.
Its mentioned in the red confirm box below
|
Changes to language look good to me. |
|
As well with me |
Enable and Install were split into two different expressions. Purge was renamed to uninstall to make clearer what is going to happen. PHPBB3-11994
PHPBB3-11994
PHPBB3-11994
PHPBB3-11994
PHPBB3-11994
PHPBB3-11994
PHPBB3-11994
|
@imkingdavid rebased |
[ticket/11994] Make extension manager UI less misleading
Enable and Install were split into two different expressions.
Purge was renamed to uninstall to make clearer what is going to happen.
http://tracker.phpbb.com/browse/PHPBB3-11994