Ticket/11995 Fix Revert of config.remove migration #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPBB3-11995
| { | ||
| $this->tool->reverse('remove', 'foo'); | ||
| } | ||
| catch (Exception $e) |
There was a problem hiding this comment.
Is an explicit catch necessary?
There was a problem hiding this comment.
its just a copy from all the code around, should I change all of them?
| try | ||
| { | ||
| $this->tool->add('foo', 'bar'); | ||
| $this->fail('Exception not thrown'); |
There was a problem hiding this comment.
Why was this test removed? We're trying to make sure an exception is thrown when adding a config var that already exists.
There was a problem hiding this comment.
Forgot, exceptions are not thrown for this reason anymore.
There was a problem hiding this comment.
If you expect an exception, you should be using the @expectedException annotation if possible. If an exception is unexpected, phpunit should turn them into a failure automatically.
EXreaction
added a commit
that referenced
this pull request
Nov 2, 2013
Ticket/11995 Fix Revert of config.remove migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.phpbb.com/browse/PHPBB3-11995