Ticket/12240 - Adds specific class to BBCode-Buttons in Template incl. Custom-BBCode support #2074

Merged
merged 4 commits into from Mar 9, 2014

3 participants

@Crizz0
phpBB Forum Software member

Adds specific class to BBCode-Buttons in Template incl. Custom-BBCode support.

http://tracker.phpbb.com/browse/PHPBB3-12240

@prototech
phpBB Forum Software member

subsilver2?

@Crizz0
phpBB Forum Software member

I don't like this style, so i forget it always. But i will do it now. ;)

@nickvergessen nickvergessen commented on an outdated diff Mar 2, 2014
phpBB/styles/prosilver/template/posting_buttons.html
<!-- BEGIN custom_tags -->
- <input type="button" class="button2" name="addbbcode{custom_tags.BBCODE_ID}" value="{custom_tags.BBCODE_TAG}" onclick="bbstyle({custom_tags.BBCODE_ID})" title="{custom_tags.BBCODE_HELPLINE}" />
+ <input type="button" class="button2 {custom_tags.BBCODE_TAG_CLEAN}" name="addbbcode{custom_tags.BBCODE_ID}" value="{custom_tags.BBCODE_TAG}" onclick="bbstyle({custom_tags.BBCODE_ID})" title="{custom_tags.BBCODE_HELPLINE}" />
@nickvergessen
phpBB Forum Software member

should be bbcode-{custom_tags.BBCODE_TAG_CLEAN}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@nickvergessen nickvergessen commented on an outdated diff Mar 2, 2014
phpBB/styles/subsilver2/template/posting_buttons.html
@@ -78,7 +78,7 @@
<td colspan="2">
<div id="custom-bbcode-buttons">
<!-- BEGIN custom_tags -->
- <input type="button" class="btnbbcode" name="addbbcode{custom_tags.BBCODE_ID}" value="{custom_tags.BBCODE_TAG}" onclick="bbstyle({custom_tags.BBCODE_ID})"<!-- IF custom_tags.BBCODE_HELPLINE !== '' --> onmouseover="helpline('cb_{custom_tags.BBCODE_ID}')" onmouseout="helpline('tip')"<!-- ENDIF --> />
+ <input type="button" class="btnbbcode {custom_tags.BBCODE_TAG_CLEAN}" name="addbbcode{custom_tags.BBCODE_ID}" value="{custom_tags.BBCODE_TAG}" onclick="bbstyle({custom_tags.BBCODE_ID})"<!-- IF custom_tags.BBCODE_HELPLINE !== '' --> onmouseover="helpline('cb_{custom_tags.BBCODE_ID}')" onmouseout="helpline('tip')"<!-- ENDIF --> />
@nickvergessen
phpBB Forum Software member

should be bbcode-{custom_tags.BBCODE_TAG_CLEAN}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech prototech commented on an outdated diff Mar 2, 2014
phpBB/styles/prosilver/template/posting_buttons.html
<!-- ENDIF -->
- <select name="addbbcode20" onchange="bbfontstyle('[size=' + this.form.addbbcode20.options[this.form.addbbcode20.selectedIndex].value + ']', '[/size]');this.form.addbbcode20.selectedIndex = 2;" title="{L_BBCODE_F_HELP}">
+ <select name="addbbcode20" class="bbcode-fontsize" onchange="bbfontstyle('[size=' + this.form.addbbcode20.options[this.form.addbbcode20.selectedIndex].value + ']', '[/size]');this.form.addbbcode20.selectedIndex = 2;" title="{L_BBCODE_F_HELP}">
@prototech
phpBB Forum Software member

Should be bbcode-size if we're following the convention of using the actual bbcode name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@prototech prototech commented on an outdated diff Mar 2, 2014
phpBB/styles/prosilver/template/posting_buttons.html
@@ -91,9 +91,9 @@
<!-- ENDIF -->
<!-- ENDIF -->
</select>
- <input type="button" class="button2" name="bbpalette" id="bbpalette" value="{L_FONT_COLOR}" onclick="change_palette();" title="{L_BBCODE_S_HELP}" />
+ <input type="button" class="button2 bbcode-fontcolor" name="bbpalette" id="bbpalette" value="{L_FONT_COLOR}" onclick="change_palette();" title="{L_BBCODE_S_HELP}" />
@prototech
phpBB Forum Software member

bbcode-color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@EXreaction EXreaction merged commit c305bd2 into phpbb:develop Mar 9, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment