Ticket/12342 Javascript Bugs and Fixes #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function was being called before dE() function exists, causing it to fail. Should be called when the page/window is ready. PHPBB3-12342
| @@ -30,7 +30,7 @@ <h2 class="solo">{PAGE_TITLE}<!-- IF SEARCH_WORDS -->{L_COLON} <a href="{U_SEARC | |||
|
|
|||
| <ul class="linklist wrap"> | |||
| <li> | |||
| <!-- IF U_FIND_MEMBER and not S_SEARCH_USER --><a href="{U_FIND_MEMBER}" id="member_search" data-alt-text="{LA_HIDE_MEMBER_SEARCH}">{L_FIND_USERNAME}</a> • <!-- ELSEIF S_SEARCH_USER and U_HIDE_FIND_MEMBER and not S_IN_SEARCH_POPUP --><a href="{U_HIDE_FIND_MEMBER}" id="member_search" data-alt-text="{LA_FIND_USERNAME}">{L_HIDE_MEMBER_SEARCH}</a> • <!-- ENDIF --> | |||
| <!-- IF U_FIND_MEMBER and not S_SEARCH_USER --><a href="{U_FIND_MEMBER}" id="member_search" data-ajax="alt_text" data-alt-text="{LA_HIDE_MEMBER_SEARCH}">{L_FIND_USERNAME}</a> • <!-- ELSEIF S_SEARCH_USER and U_HIDE_FIND_MEMBER and not S_IN_SEARCH_POPUP --><a href="{U_HIDE_FIND_MEMBER}" id="member_search" data-ajax="alt_text" data-alt-text="{LA_FIND_USERNAME}">{L_HIDE_MEMBER_SEARCH}</a> • <!-- ENDIF --> | |||
There was a problem hiding this comment.
isn't the alt_text here duplicate of https://github.com/phpbb/phpbb/pull/2229/files#diff-c4a89ebc14a8dd561ba742e24e328cbeR390 ?
Also this added the waiting-circle icon (which i dont really understand why it is needed at all)
This should not be an ajax call, just pure JS?
|
Updated. You're right. The real problem was in the core.js file. That has been fixed. Now the member list show/hide toggles without any spinner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.phpbb.com/browse/PHPBB3-12342
chosen a custom date, any time the UCP Global Prefs page loads,
it should reveal to the user the normally hidden custom date field.
This function was being triggered at the wrong time, so it was trying
to use functions that did not exists yet.
PHPBB3-12342