[ticket/12347] Move breadcrumb seperator from template to CSS #2241
Conversation
|
When committing, please make sure it merges correctly with #2233 |
| <span class="crumb"><a href="{U_INDEX}" accesskey="h"{$MICRODATA}>{L_INDEX}</a></span> | ||
| <!-- BEGIN navlinks --> <span class="crumb"><strong>‹</strong> <a href="{navlinks.U_VIEW_FORUM}"{$MICRODATA}>{navlinks.FORUM_NAME}</a></span><!-- END navlinks --> | ||
| <li class="small-icon icon-home breadcrumbs"> | ||
| <!-- IF U_SITE_HOME --><span class="crumb"><a href="{U_SITE_HOME}"{$MICRODATA}>{L_SITE_HOME}</a></span><!-- ENDIF --><span class="crumb"><a href="{U_INDEX}" accesskey="h"{$MICRODATA}>{L_INDEX}</a></span><!-- BEGIN navlinks --><span class="crumb"><a href="{navlinks.U_VIEW_FORUM}"{$MICRODATA}>{navlinks.FORUM_NAME}</a></span><!-- EVENT overall_header_navlink_append --><!-- END navlinks --> |
There was a problem hiding this comment.
please break the line again, it's too long
|
Can you update this now? |
|
Will do |
| word-wrap: normal; | ||
| } | ||
|
|
||
| .breadcrumbs .crumb:after { |
There was a problem hiding this comment.
I think it should be assigned to .crumb:before
There was a problem hiding this comment.
Since we have to deal with the home icon:
ul.linklist li.small-icon > a, ul.linklist li.breadcrumbs span:first-child > a {
display: inline-block;
padding-left: 17px;
}I thought using :after would have less potential for issues (in case the :first-of-type breaks due to possible sloppy extensions).
There was a problem hiding this comment.
well the arrow is caused by the following element, not by the previous one. So before is really what it should be (if its not too difficult)
PHPBB3-12347
| padding: 0 0.5em; | ||
| } | ||
|
|
||
| .breadcrumbs .crumb:first-of-type:before { |
There was a problem hiding this comment.
first-of-type does not work in IE8. Use first-child instead.
PHPBB3-12347
PHPBB3-12347
It seems to work fine with the responsive breadcrumbs script. The bidi.css might need some work (although it works fine in general), but the bidi.css needs overall work. There are other issues that need to be solved first.
Lastly: before anyone asks, you cannot use HTML special characters in CSS
content:'', so I used the display value, which is the preferred method for CSS (as far as I know).PHPBB3-12347