Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[ticket/12380] Sort Remember Me keys by last login time in UCP #2281
Conversation
PHPBB3-12380
@@ -672,7 +672,8 @@ function main($id, $mode) | |||
$sql = 'SELECT key_id, last_ip, last_login | |||
FROM ' . SESSIONS_KEYS_TABLE . ' | |||
WHERE user_id = ' . (int) $user->data['user_id']; | |||
WHERE user_id = ' . (int) $user->data['user_id'] . ' | |||
ORDER BY last_login'; |
This comment has been minimized.
This comment has been minimized.
PHPBB3-12380
This comment has been minimized.
This comment has been minimized.
Updated |
@@ -672,7 +672,8 @@ function main($id, $mode) | |||
$sql = 'SELECT key_id, last_ip, last_login | |||
FROM ' . SESSIONS_KEYS_TABLE . ' | |||
WHERE user_id = ' . (int) $user->data['user_id']; | |||
WHERE user_id = ' . (int) $user->data['user_id'] . ' | |||
ORDER BY last_login ASC'; |
This comment has been minimized.
This comment has been minimized.
bantu
Apr 10, 2014
Member
Did you pick the sorting direction arbitrarily? I am wondering whether DESC makes more sense, "last used first".
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nickvergessen
Apr 10, 2014
Contributor
Could also make the column names clickable and allow sorting by all 3 values in both directions.
Otherwise I would prefer DESC aswell, then you can start checking the "mark" box starting at a certain date rather then stop :P
This comment has been minimized.
This comment has been minimized.
VSEphpbb
Apr 10, 2014
Author
Member
I discussed that on IRC. I think making columns sortable is overkill. loginkeys is not an important list. there usually won't be many loginkeys listed. and its not like a user NEEDS to have them sorted either upwards or downwards for any reason.
I figured oldest at top made sense, because those would be the first ones a user would delete… so they can work their way down the list until they reach their most recent login keys.
This comment has been minimized.
This comment has been minimized.
eb6b877
into
phpbb:develop-ascraeus
VSEphpbb commentedApr 10, 2014
https://tracker.phpbb.com/browse/PHPBB3-12380
PHPBB3-12380