[feature/sqlite3] Add support for SQLite 3 #2351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** | ||
| * SQL Transaction | ||
| * @access private |
There was a problem hiding this comment.
Missing @param and @return
Minimum version requirement is 3.6.15 as that's what ships with PHP 5.3.0 when support for SQLite 3 was added. PHPBB3-9728
Added missing docblock annotations and added visibility identifiers. PHPBB3-9728
[feature/sqlite3] Remove trailing comma from column list
[feature/sqlite3] Fix sql_index_drop() and recreate indexes after actions
| FROM sqlite_master | ||
| WHERE type = 'table' | ||
| AND name = '" . $db->sql_escape($table_name) . "' | ||
| ORDER BY type DESC, name;"; |
There was a problem hiding this comment.
type DESC is pointless as there is only one such value
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum version requirement is 3.6.15 as that's what ships with PHP 5.3.0
when support for SQLite 3 was added.
PHPBB3-9728